precompiles: Validate and preprocess expmod input #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfast
added
precompiles
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1195 +/- ##
==========================================
- Coverage 94.89% 94.82% -0.08%
==========================================
Files 171 171
Lines 19687 19406 -281
==========================================
- Hits 18682 18401 -281
Misses 1005 1005
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast
force-pushed
the
precompiles/expmod_input
branch
from
f5fc6d3 to
8af3ec8
Compare
rodiazet
approved these changes
Apr 15, 2025
chfast
force-pushed
the
precompiles/fix_expmod_gas
branch
from
45b766f to
f322609
Compare
chfast
force-pushed
the
precompiles/expmod_input
branch
from
8af3ec8 to
e015ea5
Compare
Decompose the expmod input into separate bytes_views for base, exp, mod. Handle arguments padding. Handle mod being zero. Simplify and vastly reduce the expmod stub by using the preprocessed arguments and handling trivial cases before doing the result lookup.
chfast
force-pushed
the
precompiles/expmod_input
branch
from
e015ea5 to
36e817f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decompose the expmod input into separate bytes_views for base, exp, mod. Handle arguments padding. Handle mod being zero.
Simplify and vastly reduce the expmod stub by using the preprocessed arguments and handling trivial cases before doing the result lookup.